dspico/pico-launcher
1
0
Fork 0
mirror of https://github.com/LNH-team/pico-launcher.git synced 2026-06-02 09:06:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change cheat implementation to show cheats in database order, fix some bugs

Browse Source 
- AdvancedPaletteManager incorrectly handled negative y positions
- FocusManager still had a pointer to a view that was destroyed in the cheats panel. After changing focus, memory got corrupted.
This commit is contained in:
Gericom
2026-03-15 13:28:59 +01:00
parent 601fd6371e
commit b7d7f9f352
16 changed files with 313 additions and 424 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
arm9/source/romBrowser/viewModels/CheatsViewModel.cpp
View File

@@ -33,39 +33,40 @@ void CheatsViewModel::ActivateSelectedItem()
}
auto cheatCategory = GetCurrentCheatCategory();
u32 numberOfCategories = 0;
auto categories = cheatCategory->GetCategories(numberOfCategories);
u32 numberOfCheats = 0;
auto cheats = cheatCategory->GetCheats(numberOfCheats);
u32 numberOfSubEntries = 0;
auto subEntries = cheatCategory->GetSubEntries(numberOfSubEntries);
if (numberOfCategories + numberOfCheats == 0)
if (numberOfSubEntries == 0)
{
// There is nothing to activate
return;
}
if (_selectedItem < (int)numberOfCategories)
auto& entry = subEntries[_selectedItem];
if (entry.IsCheatCategory())
{
// Category activated
if (_categoryStackLevel + 1 != _categoryStack.size())
{
_categoryStack[++_categoryStackLevel] = { &categories[_selectedItem], (u32)_selectedItem };
_categoryStack[++_categoryStackLevel] = { &entry, (u32)_selectedItem };
_selectedItem = 0;
}
}
else
{
// Toggle cheat on/off
auto& cheat = cheats[_selectedItem - numberOfCategories];
bool isEnabled = !cheat.GetIsCheatActive();
bool isEnabled = !entry.GetIsCheatActive();
if (isEnabled && cheatCategory->GetIsMaxOneCheatActive())
{
for (u32 i = 0; i < numberOfCheats; i++)
for (u32 i = 0; i < numberOfSubEntries; i++)
{
cheats[i].SetIsCheatActive(false);
if (!subEntries[i].IsCheatCategory())
{
subEntries[i].SetIsCheatActive(false);
}
}
}
cheat.SetIsCheatActive(isEnabled);
entry.SetIsCheatActive(isEnabled);
_changed = true;
}
}
@@ -111,23 +112,24 @@ void CheatsViewModel::DisableAllCheats()
}
}
void CheatsViewModel::DisableAllCheats(const ICheatCategory* cheatCategory)
void CheatsViewModel::DisableAllCheats(const CheatEntry* cheatCategory)
{
u32 numberOfCategories = 0;
auto categories = cheatCategory->GetCategories(numberOfCategories);
for (u32 i = 0; i < numberOfCategories; i++)
u32 numberOfSubEntries = 0;
auto subEntries = cheatCategory->GetSubEntries(numberOfSubEntries);
for (u32 i = 0; i < numberOfSubEntries; i++)
{
DisableAllCheats(&categories[i]);
}
u32 numberOfCheats = 0;
auto cheats = cheatCategory->GetCheats(numberOfCheats);
for (u32 i = 0; i < numberOfCheats; i++)
{
if (cheats[i].GetIsCheatActive())
auto& entry = subEntries[i];
if (entry.IsCheatCategory())
{
cheats[i].SetIsCheatActive(false);
_changed = true;
DisableAllCheats(&entry);
}
else
{
if (entry.GetIsCheatActive())
{
entry.SetIsCheatActive(false);
_changed = true;
}
}
}
}

6
arm9/source/romBrowser/viewModels/CheatsViewModel.h
View File

@@ -44,7 +44,7 @@ public:
/// @brief Gets the current cheat category.
/// @return The current cheat category.
const ICheatCategory* GetCurrentCheatCategory() const { return _categoryStack[_categoryStackLevel].cheatCategory; }
const CheatEntry* GetCurrentCheatCategory() const { return _categoryStack[_categoryStackLevel].cheatCategory; }
/// @brief Gets the index of the selected item.
/// @return The index of the selected item.
@@ -64,7 +64,7 @@ public:
private:
struct CategoryStackEntry
{
const ICheatCategory* cheatCategory;
const CheatEntry* cheatCategory;
u32 index;
};
@@ -78,5 +78,5 @@ private:
u32 _categoryStackLevel = 0;
std::array<CategoryStackEntry, 8> _categoryStack;
void DisableAllCheats(const ICheatCategory* cheatCategory);
void DisableAllCheats(const CheatEntry* cheatCategory);
};