diff --git a/RetroFE/Source/CMakeLists.txt b/RetroFE/Source/CMakeLists.txt index 496b74a..961adbf 100644 --- a/RetroFE/Source/CMakeLists.txt +++ b/RetroFE/Source/CMakeLists.txt @@ -175,7 +175,6 @@ add_executable(RetroFE ${RETROFE_SOURCES} ${RETROFE_HEADERS}) target_link_libraries(RetroFE ${RETROFE_LIBRARIES}) set_target_properties(RetroFE PROPERTIES LINKER_LANGUAGE CXX) if(MINGW) - set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -mwindows") set(CMAKE_EXE_LINKER_FLAGS "-static-libgcc -static-libstdc++ -mwindows") endif() @@ -191,4 +190,8 @@ if(MSVC) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /MP /WX") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /MP /WX") set_target_properties(RetroFE PROPERTIES LINK_FLAGS "/SUBSYSTEM:WINDOWS") -endif() \ No newline at end of file +else() + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall") + set(CMAKE_C_FLAGS "${CMAKE_CXX_FLAGS} -Wall") +endif() + diff --git a/RetroFE/Source/Collection/CollectionInfoBuilder.cpp b/RetroFE/Source/Collection/CollectionInfoBuilder.cpp index dfe442e..e37aec4 100644 --- a/RetroFE/Source/Collection/CollectionInfoBuilder.cpp +++ b/RetroFE/Source/Collection/CollectionInfoBuilder.cpp @@ -72,7 +72,6 @@ CollectionInfo *CollectionInfoBuilder::BuildCollection(std::string name) } CollectionInfo *collection = new CollectionInfo(name, listItemsPath, extensions, metadataType, metadataPath); - std::vector *list = collection->GetItems(); ImportDirectory(collection); @@ -80,7 +79,7 @@ CollectionInfo *CollectionInfoBuilder::BuildCollection(std::string name) } -bool CollectionInfoBuilder::ImportBasicList(CollectionInfo *info, std::string file, std::map &list) +bool CollectionInfoBuilder::ImportBasicList(CollectionInfo * /*info*/, std::string file, std::map &list) { std::ifstream includeStream(file.c_str()); @@ -116,7 +115,6 @@ bool CollectionInfoBuilder::ImportDirectory(CollectionInfo *info) std::string path = info->GetListPath(); std::map includeFilter; std::map excludeFilter; - bool retVal = true; std::string includeFile = Configuration::GetAbsolutePath() + "/Collections/" + info->GetName() + "/Include.txt"; std::string excludeFile = Configuration::GetAbsolutePath() + "/Collections/" + info->GetName() + "/Exclude.txt"; std::string launcher; diff --git a/RetroFE/Source/Graphics/Component/ScrollingList.cpp b/RetroFE/Source/Graphics/Component/ScrollingList.cpp index e40a475..c6d112d 100644 --- a/RetroFE/Source/Graphics/Component/ScrollingList.cpp +++ b/RetroFE/Source/Graphics/Component/ScrollingList.cpp @@ -467,7 +467,6 @@ void ScrollingList::TriggerMenuExitEvent() void ScrollingList::Update(float dt) { - float scrollPeriod = 0; bool initializePoints = false; Component::Update(dt); diff --git a/RetroFE/Source/Graphics/Component/VideoComponent.cpp b/RetroFE/Source/Graphics/Component/VideoComponent.cpp index 000339d..9278b2d 100644 --- a/RetroFE/Source/Graphics/Component/VideoComponent.cpp +++ b/RetroFE/Source/Graphics/Component/VideoComponent.cpp @@ -100,6 +100,6 @@ void VideoComponent::Draw() if(texture) { - SDL::RenderCopy(texture, static_cast(info->GetAlpha() * 255), NULL, &rect, info->GetAngle()); + SDL::RenderCopy(texture, static_cast(info->GetAlpha() * 255), NULL, &rect, static_cast(info->GetAngle())); } } diff --git a/RetroFE/Source/Main.cpp b/RetroFE/Source/Main.cpp index 20ef31e..c055f35 100644 --- a/RetroFE/Source/Main.cpp +++ b/RetroFE/Source/Main.cpp @@ -27,7 +27,7 @@ static bool ImportConfiguration(Configuration *c); static bool StartLogging(); -int main(int argc, char *argv[]) +int main(int /* argc */, char ** /* argv */) { Configuration::Initialize(); diff --git a/RetroFE/Source/RetroFE.cpp b/RetroFE/Source/RetroFE.cpp index 0826356..7b4c332 100644 --- a/RetroFE/Source/RetroFE.cpp +++ b/RetroFE/Source/RetroFE.cpp @@ -71,7 +71,6 @@ void RetroFE::Render() int RetroFE::Initialize(void *context) { - int retVal = 0; RetroFE *instance = static_cast(context); Logger::Write(Logger::ZONE_INFO, "RetroFE", "Initializing"); @@ -150,8 +149,6 @@ bool RetroFE::DeInitialize() bool retVal = true; FreeGraphicsMemory(); - bool videoEnable = true; - if(CurrentPage) { delete CurrentPage; @@ -201,8 +198,6 @@ void RetroFE::Run() int attractModeTime = 0; std::string firstCollection = "Main"; bool running = true; - Item *nextPageItem = NULL; - bool adminMode = false; RETROFE_STATE state = RETROFE_NEW; Config.GetProperty("attractModeTime", attractModeTime); diff --git a/RetroFE/Source/Video/GStreamerVideo.cpp b/RetroFE/Source/Video/GStreamerVideo.cpp index be159b8..fae2404 100644 --- a/RetroFE/Source/Video/GStreamerVideo.cpp +++ b/RetroFE/Source/Video/GStreamerVideo.cpp @@ -33,8 +33,8 @@ bool GStreamerVideo::Initialized = false; //todo: this started out as sandbox code. This class needs to be refactored // MUST match video size -gboolean GStreamerVideo::BusCallback(GstBus *bus, GstMessage *msg, gpointer data) -{ +gboolean GStreamerVideo::BusCallback(GstBus * /* bus */, GstMessage * /* msg */, gpointer /* data */) +{ // this callback only needs to be defined so we can loop the video once it completes return TRUE; } @@ -85,7 +85,7 @@ SDL_Texture *GStreamerVideo::GetTexture() const return Texture; } -void GStreamerVideo::ProcessNewBuffer (GstElement *fakesink, GstBuffer *buf, GstPad *new_pad, gpointer userdata) +void GStreamerVideo::ProcessNewBuffer (GstElement * /* fakesink */, GstBuffer *buf, GstPad *new_pad, gpointer userdata) { GStreamerVideo *video = (GStreamerVideo *)userdata; GstMapInfo map; @@ -345,7 +345,7 @@ void GStreamerVideo::Draw() FrameReady = false; } -void GStreamerVideo::Update(float dt) +void GStreamerVideo::Update(float /* dt */) { SDL_LockMutex(SDL::GetMutex()); if(!Texture && Width != 0 && Height != 0)