From 0c17703b464014ca655338663654cb81e5c246da Mon Sep 17 00:00:00 2001 From: TJ Borromeo Date: Wed, 6 May 2015 13:39:32 -0700 Subject: [PATCH 1/3] change return type allows the error check to be more functional --- httpserver-header.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/httpserver-header.lua b/httpserver-header.lua index 38b5b6a..599c3e5 100644 --- a/httpserver-header.lua +++ b/httpserver-header.lua @@ -8,7 +8,7 @@ return function (connection, code, extension) local codez = {[200]="OK", [400]="Bad Request", [404]="Not Found", [501]="Not Implemented",} local myResult = codez[code] -- enforce returning valid http codes all the way throughout? - if myResult then return myResult else return codez[501] end + if myResult then return {[code]=myResult,} else return {[501]=codez[501],} end end local function getMimeType(ext) From e01e97469f3a9dfc42ab5daa3e6a90dcb6b37102 Mon Sep 17 00:00:00 2001 From: TJ Borromeo Date: Wed, 6 May 2015 13:42:06 -0700 Subject: [PATCH 2/3] Update httpserver-header.lua --- httpserver-header.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/httpserver-header.lua b/httpserver-header.lua index 599c3e5..b3f9134 100644 --- a/httpserver-header.lua +++ b/httpserver-header.lua @@ -5,10 +5,10 @@ return function (connection, code, extension) local function getHTTPStatusString(code) - local codez = {[200]="OK", [400]="Bad Request", [404]="Not Found", [501]="Not Implemented",} + local codez = {[200]="OK", [400]="Bad Request", [404]="Not Found",} local myResult = codez[code] -- enforce returning valid http codes all the way throughout? - if myResult then return {[code]=myResult,} else return {[501]=codez[501],} end + if myResult then return {[code]=myResult,} else return {[501]="Not Implemented",} end end local function getMimeType(ext) From 2672d3b46701374fccb7b84121e190ab72d2ad33 Mon Sep 17 00:00:00 2001 From: TJ Borromeo Date: Wed, 6 May 2015 13:54:21 -0700 Subject: [PATCH 3/3] Keep return type as is No need for 501 error code, as this should be returned only when needed, and will be much more efficient to not: 1.) take a table entry for the majority of cases when it isn't needed 2.) Utilize only enough memory needed to instantiate a string when it _is_ needed. --- httpserver-header.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/httpserver-header.lua b/httpserver-header.lua index b3f9134..5f01ef7 100644 --- a/httpserver-header.lua +++ b/httpserver-header.lua @@ -8,7 +8,7 @@ return function (connection, code, extension) local codez = {[200]="OK", [400]="Bad Request", [404]="Not Found",} local myResult = codez[code] -- enforce returning valid http codes all the way throughout? - if myResult then return {[code]=myResult,} else return {[501]="Not Implemented",} end + if myResult then return myResult else return "Not Implemented" end end local function getMimeType(ext)