From f6df5e11585ce0ddf5e7709cf5a7d3d55f8e6840 Mon Sep 17 00:00:00 2001
From: Maximilian Rehkopf <ikari@elektra.(none)>
Date: Sat, 8 Oct 2011 19:25:46 +0200
Subject: [PATCH] Firmware: remove magic number for XModem block size

---
 src/xmodem.c | 11 +++--------
 src/xmodem.h |  6 ++++++
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/xmodem.c b/src/xmodem.c
index d8366f0..979f8d4 100644
--- a/src/xmodem.c
+++ b/src/xmodem.c
@@ -5,13 +5,8 @@
 #include "ff.h"
 #include "xmodem.h"
 
-#define ASC_ACK	(0x06)
-#define ASC_NAK (0x15)
-#define ASC_SOH (0x01)
-#define ASC_EOT (0x04)
-
 void xmodem_rxfile(FIL* fil) {
-  uint8_t rxbuf[128], sum=0, sender_sum;
+  uint8_t rxbuf[XMODEM_BLKSIZE], sum=0, sender_sum;
   uint8_t blknum, blknum2;
   uint8_t count;
   uint32_t totalbytes = 0;
@@ -26,12 +21,12 @@ void xmodem_rxfile(FIL* fil) {
   do {
     blknum=uart_getc();
     blknum2=uart_getc();
-    for(count=0; count<128; count++) {
+    for(count=0; count<XMODEM_BLKSIZE; count++) {
       sum += rxbuf[count] = uart_getc();
       totalbytes++;
     }
     sender_sum = uart_getc();
-    res=f_write(fil, rxbuf, 128, &written);
+    res=f_write(fil, rxbuf, XMODEM_BLKSIZE, &written);
     totalwritten += written;
     uart_putc(ASC_ACK);
   } while (uart_getc() != ASC_EOT);
diff --git a/src/xmodem.h b/src/xmodem.h
index 9a1c31f..a5a563c 100644
--- a/src/xmodem.h
+++ b/src/xmodem.h
@@ -3,6 +3,12 @@
 
 #include "ff.h"
 
+#define ASC_ACK (0x06)
+#define ASC_NAK (0x15)
+#define ASC_SOH (0x01)
+#define ASC_EOT (0x04)
+#define XMODEM_BLKSIZE (128)
+
 void xmodem_rxfile(FIL* fil);
 
 #endif