godzil/wmfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tag_new() tag name

Browse Source 
possible overflow + random memory access
This commit is contained in:
Philippe Pepiot
2010-12-03 11:06:33 +01:00
parent c90a5743b3
commit 77e458048d
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/tag.c
View File

@@ -508,18 +508,20 @@ tag_new(int s, char *name)
++conf.ntag[s]; ++conf.ntag[s];
/* TODO: memleak here */
if(!name || strlen(name) == 0) if(!name || strlen(name) == 0)
{ {
if(conf.tagnamecount) if(conf.tagnamecount)
{ {
displayedName = zmalloc(2); /* displayedName = zmalloc(2); */
sprintf(displayedName, "[%d]", conf.ntag[s]); xasprintf(&displayedName, "[%d]", conf.ntag[s]);
} }
else else
displayedName = conf.default_tag.name; displayedName = conf.default_tag.name;
} }
else else
displayedName = name; displayedName = xstrdup(name);
Tag t = { displayedName, NULL, 0, 0, Tag t = { displayedName, NULL, 0, 0,
conf.default_tag.mwfact, conf.default_tag.nmaster, conf.default_tag.mwfact, conf.default_tag.nmaster,