From b9e67982f8bf1c4992755c3bde6085a7f0a0e093 Mon Sep 17 00:00:00 2001 From: Philippe Pepiot Date: Wed, 21 Sep 2011 15:53:58 +0200 Subject: [PATCH] Fix possible leak in parse.c. Fixes #149 If stat() fail and open() worked, file wasn't closed Reported-by: mlq Signed-off-by: Philippe Pepiot --- src/parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parse.c b/src/parse.c index d0c4a79..e6d96f2 100644 --- a/src/parse.c +++ b/src/parse.c @@ -165,7 +165,7 @@ parse_keywords(const char *filename) bool error = False; - if ((fd = open(filename, O_RDONLY)) == -1 || stat(filename, &st) == -1) { + if (stat(filename, &st) == -1 || (fd = open(filename, O_RDONLY)) == -1) { warn("%s", filename); return NULL; }