Commit Graph

62 Commits

Author SHA1 Message Date
Lei Maohui
f947a3d4a1 polkit: Fix multilib builds
Recover ${nonarch_libdir}/${BPN}-1 into FILES:${PN} to fix install do_package error when multilib is enabled.
Fixes

ERROR: polkit-122-r0 do_package: QA Issue: polkit: Files/directories were installed but not shipped in any package:
  /usr/lib/polkit-1/polkit-agent-helper-1
  /usr/lib/polkit-1/polkitd
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
polkit: 2 installed and not shipped files. [installed-vs-shipped]

Signed-off-by: Lei Maohui <leimaohui@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-12-08 17:10:44 -08:00
Markus Volk
64e7d871aa polkit: add recipe for v122
autotools buildsystem has been dropped

Signed-off-by: Markus Volk <f_l_k@t-online.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-11-28 11:20:00 -08:00
Chen Qi
f2feb70bff polkit: refresh patch
Refresh patch to avoid QA issue about patch fuzz.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-09-27 10:04:35 -07:00
Sergio Prado
0d5a3e6755 polkit: refresh patch to fix warning
Fix the following warning:

WARNING: polkit-0.119-r0 do_patch: Fuzz detected:

Applying patch 0004-Make-netgroup-support-optional.patch
patching file configure.ac
Hunk #1 succeeded at 117 with fuzz 2 (offset 17 lines).
patching file meson.build
patching file src/polkit/polkitidentity.c
patching file src/polkit/polkitunixnetgroup.c
patching file src/polkitbackend/polkitbackendinteractiveauthority.c
patching file src/polkitbackend/polkitbackendjsauthority.cpp
Hunk #1 succeeded at 1291 (offset -233 lines).
Hunk #2 succeeded at 1306 (offset -233 lines).
patching file test/polkit/polkitidentitytest.c
patching file test/polkit/polkitunixnetgrouptest.c
patching file test/polkitbackend/test-polkitbackendjsauthority.c

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-09-05 22:49:34 -07:00
Marta Rybczynska
271282b1a5 polkit: update patches for musl compilation
Update the patch to make netgroup support optional to fit the commit
merged upstream [1], update the other patch depending on one of the
changes.

Without this update, a compilation using duktape with musl fails with:
| ../../../polkit-0.119/src/polkitbackend/polkitbackendduktapeauthority.c: In function 'js_polkit_user_is_in_netgroup':
| ../../../polkit-0.119/src/polkitbackend/polkitbackendduktapeauthority.c:1039:7: warning: implicit declaration of function 'innetgr' [-Wimplicit-function-declaration]
|  1039 |   if (innetgr (netgroup,
|       |       ^~~~~~~

The main patch has been split in two, to apply the duktape part only when duktape is
applied.

[1] b57deee817

Signed-off-by: Marta Rybczynska <marta.rybczynska@huawei.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-07-29 09:18:14 -07:00
Akash Hadke
7ca63e5454 polkit: Add --shell /bin/nologin to polkitd user
polkitd user has default access to /bin/sh, add --shell /bin/nologin
to remove default access to /bin/sh and avoid login through it.

Signed-off-by: Akash Hadke <akash.hadke@kpit.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-07-28 08:34:19 -07:00
Yi Zhao
10b508deac polkit-group-rule-udisks2: fix override syntax in RDEPENDS
RDEPENDS_${PN} -> RDEPENDS:${PN}

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-06-30 13:39:28 -04:00
Mikko Rapeli
461ceffc48 polkit: switch back to mozjs but leave duktape as PACKAGECONFIG option
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14829 reports
that duktape isn't fully compatible with mozjs as the supported
javascript features are different. duktape supports
ECMAScript standard version 5 while mozjs supports a lot more.
See https://kangax.github.io/compat-table/es5/ for the differences.
Thus the change from mozjs to duktape may break some rules
which rely on javascript features which duktape doesn't support,
for example array.includes() function,
https://kangax.github.io/compat-table/es6/
https://262.ecma-international.org/7.0/#sec-array.prototype.includes

For many embedded systems which care about fast boot times and smaller
rootfs using duktape is recommended but rules must be written in reduced
set of ECMA script language features. For array.includes() one alternative
is "array.indexOf(search) >= 0".

[YOCTO #14829]

Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-06-30 13:39:27 -04:00
Vyacheslav Yurkov
d7ff4a7724 polkit: add udisks2 rule
The rule allows non-priviledged users from plugdev group to
mount/unmount block devices

Signed-off-by: Vyacheslav Yurkov <v.yurkov@precitec.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-05-12 09:16:11 -07:00
Mikko Rapeli
3ac2678f42 polkit: switch from mozjs to duktape javascript engine
cherry-pick the change from polkit 0.120+ upstream since
it applies directly to 0.119. Drop mozjs patches.

Removes mozjs and its dependency nspr from images. They account for
roughly 21 Mb on 64bit ARM machines. The replacement libduktape is
roughly 300 kb in size. Thus this saves at least 20 Mb in rootfs size
when polkit is used.

Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-03-25 08:28:48 -07:00
Mikko Rapeli
d5eef01fce polkit: add patches for CVE-2021-4034 and CVE-2021-4115
They were available in polkit master branch and cherry-pick to
0.119 version works so pick the patches.

Signed-off-by: Mikko Rapeli <mikko.rapeli@bmw.de>
2022-03-25 08:28:48 -07:00
Scott Murray
97c904c765 polkit: Fix build with libtool 2.4.7
Delete old m4 macros, so autoreconf can repopulate it.

Fixes

libtool: Version mismatch error.  This is libtool 2.4.7, but the
libtool: definition of this LT_INIT comes from libtool 2.4.6.
libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7
libtool: and run autoconf again.

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-03-25 08:28:48 -07:00
Khem Raj
14c7d8a0d7 recipes: Update LICENSE variable to use SPDX license identifiers
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2022-03-04 17:41:45 -08:00
Andreas Müller
c410d459db polkit: Adjust to mozjs-91 in DEPENDS
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2021-11-03 06:57:48 -07:00
Alexander Kanavin
677ff7c9c6 polkit: update 0.116 -> 0.119
Sadly, the move to duktape has not yet happend, but it is on the
way, and meanwhile we can use modern mozjs at least.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2021-10-14 07:16:58 -07:00
Mingli Yu
54ce5a6e7f polkit: add the CVE tag
Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2021-09-08 21:29:52 -07:00
Mingli Yu
b65c646b25 polkit: fix CVE-2021-3560
Backport a patch [1] to fix CVE-2021-3560.

[1] a04d13affe

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2021-08-20 09:26:17 -07:00
Martin Jansa
c61dc077bb Convert to new override syntax
This is the result of automated script (0.9.1) conversion:

oe-core/scripts/contrib/convert-overrides.py .

converting the metadata to use ":" as the override character instead of "_".

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2021-08-03 10:21:25 -07:00
Denys Dmytriyenko
4c00e5fed9 recipes: rename distro_features_check to features_check
Avoid warning due to the class rename in OE-Core.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-11-21 17:51:37 -08:00
Andreas Müller
a47d385612 polkit-group-rules: Fix error in do_rootfs for rpm package-manager
* An issue in meta-mortsgna was reported. Discussion is found at [1]
* We do similar in meta-gnome's gvfs for same reason [2]
* This is a bugfix which should apply and work for many release-branches

Fixes:
| Error: Transaction check error:
|   file /etc/polkit-1/rules.d conflicts between attempted installs of polkit-group-rule-datetime-1.0-r0.cortexa7t2hf_neon_vfpv4 and polkit-0.115-r0.cortexa7t2hf_neon_vfpv4

[1] https://github.com/schnitzeltony/meta-mortsgna/issues/11
[2] fd1a0c9210/meta-gnome/recipes-gnome/gvfs/gvfs_1.41.2.bb (L72)

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-10-09 23:27:15 -07:00
Khem Raj
866daa14e3 polkit: Upgrade to 0.116
Make netgroup support optional so it can be disabled on musl
Drop backported patch 0001-backend-Compare-PolkitUnixProcess-uids-for-temporary.patch

Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-05-29 02:26:16 -07:00
Qi.Chen@windriver.com
ec45dce920 polkit: fix CVE-2019-6133
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-05-21 08:48:56 -07:00
Nicolas Dechesne
62a8c64a02 polkit: add REQUIRED_DISTRO_FEATURES for polkit
After below commits to add polkit as a required
distro feature:
97a1a55 polkit: add polkit as a required distro feature
c049e02 polkit: inherit distro_features_check

All recipes that includes polkit-group-rule.inc will fail to parse
when polkit is not in DISTRO_FEATURE, especially 'world'. e.g.

ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'udisks', 'polkit']

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-02-22 18:14:53 -08:00
Stefan Agner
c049e02663 polkit: inherit distro_features_check
Make the recently added REQUIRED_DISTRO_FEATURES effective by
inheriting distro_features_check.

Fixes: 97a1a55f47 ("polkit: add polkit as a required distro feature")
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-01-28 07:06:19 -08:00
Stefan Agner
97a1a55f47 polkit: add polkit as a required distro feature
Make sure polkit is in DISTRO_FEATURERS if this package is being
installed. This will make sure that people who do use polkit in
their image also do enabled the recently introduced distro feature
polkit in their distro.

Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2019-01-20 10:15:44 -08:00
Hongxu Jia
5cf053a7f5 polkit: 0.113 -> 0.115
- Rebase patches to 0.115
  0001-make-netgroup-support-configurable.patch
  polkit-1_pam.patch

- Add --disable-libelogind which OE does not have recipe
  libelogind

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-07-16 18:42:41 -07:00
Andreas Müller
45664ad0ea polkit-gnome: remove
* last release was 2011
* it fails on autobuilder
* nothing uses it

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-04-13 12:43:45 -07:00
Armin Kuster
a6d8e7c3c8 polkit-gnome: only include when x11 in DISTRO_FEATURES
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-03-12 09:59:33 -07:00
Jackie Huang
19f0e8b40b polkit: add consolekit only when x11 is enabled
consolekit depends on virtual/libx11 then it requires x11
distro feature, so add consolekit option only when x11
is in DISTRO_FEATURES.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
2017-11-19 13:44:17 -08:00
Jackie Huang
0487ed7f1d recipes: fix invalid license file
Use '${COMMON_LICENSE_DIR}/MIT' for MIT License to fix the warning:

| WARNING: packagegroup-xfce-base-1.0-r5 do_populate_lic:
  ${COREBASE}/LICENSE is not a valid license file, please use
  '${COMMON_LICENSE_DIR}/MIT' for a MIT License file in LIC_FILES_CHKSUM.
  This will become an error in the future

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-09-18 10:18:12 +02:00
Robert P. J. Day
6c9c7317e2 polkit-group-rule.inc: Fix comment typo "polkid" -> "polkitd"
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-03-31 13:26:03 +02:00
Peter Kjellerstedt
0c31f55bcf Make use of the new bb.utils.filter() function
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2017-03-07 13:30:26 +01:00
Martin Jansa
289217bbc3 meta-oe: fix indentation
* remove tabs which sneaked in since last cleanup
* meta-oe layers are using consistent indentation with 4 spaces, see
  http://www.openembedded.org/wiki/Styleguide

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-08-22 15:56:28 +02:00
Ross Burton
21f10c11f3 meta-oe: use bb.utils.contains() instead of base_contains()
base_contains() is a compatibility wrapper and may warn in the future, so
replace all instances with bb.utils.contains().

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-04-28 10:38:38 +02:00
Alexander Kanavin
2ba35c90c0 polkit: fix gobject introspection support
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
2016-03-14 12:15:31 +01:00
Khem Raj
8404784b35 polkit: Fix build with musl
Make features like netgroup optional, these are not supported by posix
secondly they are poked at during configure so nothing changes for glibc
based systems but it helps compiling with musl

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-02-01 15:58:04 +01:00
Yi Zhao
a26902970c polkit-gnome: remove unrecognized configure options
Fix QA warning:
WARNING: QA Issue: polkit-gnome: configure was passed unrecognised options:
--disable-examples --disable-introspection [unknown-configure-option]

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-01-04 14:56:41 +01:00
Reinette Chatre
f86ba9a558 polkit: fix relocation of polkit binaries
Polkit is currently broken in images built with multilib and systemd.
This is because the patch, 0001-do-not-hardcoded-libdir.patch, applied on
top of the polkit source code modifies where the polkitd binary is
installed, but it does not modify the polkit.service file to start the
binary from its new location.

At first it seemed reasonable to modify the systemd service file to
search for the binary in the correct place. This change, as well as what
the patch (0001-do-not-hardcoded-libdir.patch) already does was proposed to
the polkit maintainers at https://bugs.freedesktop.org/show_bug.cgi?id=92094

During the discussion with the polkit maintainers it became apparent that the
change to support multilib polkit should not be done with a patch to
the polkit source code, but instead a change to the polkit recipe.

Polkit correctly installs libraries when multilib is in use without any
changes to its source code. What is being changed by
0001-do-not-hardcoded-libdir.patch is not where the polkit libraries are
installed but where the binaries are installed.

Installing binaries in /usr/lib when baselib is lib64 is acceptable (see
http://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s06.html ).

So, instead of patching polkit to install its binaries under the same
library directory as its libraries we maintain the design of the polkit
installer to install the binaries in /usr/lib. This is the same as what is
done in distros like Fedora that supports multilib.

With this patch the polkit package, when built with multilib, installs
files into /usr/lib* as follows:
polkit/usr/lib64/libpolkit-agent-1.so.0
polkit/usr/lib64/libpolkit-gobject-1.so.0
polkit/usr/lib64/libpolkit-gobject-1.so.0.0.0
polkit/usr/lib64/libpolkit-agent-1.so.0.0.0
polkit/usr/lib
polkit/usr/lib/polkit-1
polkit/usr/lib/polkit-1/polkitd
polkit/usr/lib/polkit-1/polkit-agent-helper-1

Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-10-13 12:28:13 +02:00
Andreas Müller
315a2f9026 polkit-group-rule.inc: remove allarch
Recipes using this include depend on polkit which is not allarch.

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-09-23 15:39:44 +02:00
Li xin
175fb66551 polkit: 0.112 -> 0.113
Remove 0001-configure.ac-Check-only-for-libsystemd-not-libsystem.patch,
it is not needed anymore.

Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-08-18 11:38:01 +02:00
Chunrong Guo
dce88e4a2c polkit: do not hardcode the libdir
libdir is defined as ${prefix}/lib/, but we want it to support multilib path

Signed-off-by: Chunrong Guo <B40290@freescale.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-05-13 14:34:24 +02:00
Khem Raj
b22ffc5f7e polkit-gnome: Upgrade 0.102 -> 0.105
add missing dep on gtk+3

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-05-13 14:34:21 +02:00
Ash Charles
b196d3e213 polkit-group-rule: Add polkitd user and group
Recipes including polkit-group-rule.inc correctly install a directory
with the user and group set as 'polkitd'.  To avoid warnings like
these when assemblying the rootfs,

  WARNING: log_check: warning: user polkitd does not exist - using root
  ...
  WARNING: log_check: warning: group polkitd does not exist - using root

create this user and group.

Note: although the polkit recipe itself, on which this depends, is
      creating this same user and group, it seems that the useradd class
      needs this to be specified independently.

Signed-off-by: Ash Charles <ashcharles@gmail.com>
Acked-by: Andreas Müller <schnitzeltony@googlemail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-02-12 19:33:24 +01:00
Martin Jansa
27a660fa7e polkit-gnome, gdm, network-manager-applet: blacklist because polkit-gnome.do_configure fails
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-12-17 12:56:21 +01:00
Andreas Müller
ceb70b7c8a polkit: update to 0.112
checked in logfile: setting up ownership/permission is performed by make install

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
2014-10-01 10:11:36 +02:00
Martin Jansa
3341f96372 polkit-gnome: remove unrecognized configure options
* fixes following QA warnings:
  polkit-gnome-0.102: polkit-gnome: configure was passed unrecognised
    options: --disable-scrollkeeper --disable-man-pages
    [unknown-configure-option]

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-08-11 10:59:22 +02:00
Richard Purdie
e29addd7d6 polkit-gnome: add missing dependency on gnome-common
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-06-21 13:06:14 +02:00
Richard Purdie
0ee1083568 recipes: add missing dependency on intltool-native
* These recipes all require intltool-native to build but were missing
  a dependency on it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-06-21 13:06:13 +02:00
Martin Jansa
acd60a9825 polkit: make it compatible with systemd-209
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-03-19 15:53:32 +01:00
Martin Jansa
6daf75e4e9 Update after toplevel LICENSE file checksum change
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2014-01-04 08:47:18 +01:00