funkey/RetroFE
1
0
Fork 0
mirror of https://github.com/FunKey-Project/RetroFE.git synced 2025-12-12 17:58:53 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix stride to next multiple of 4 when video metadata is unavailable.

Browse Source 
I've verified that playback was broken on videos with unusual dimensions on my
computers that use libav for decoding. This is apparently because the stride
must always be a multiple of 4 in gstreamer, but if this is the only padding,
it doesn't consider a GstVideoMeta necessary.
This commit is contained in:
Levi Pearson 2017-01-25 01:37:38 -07:00
parent a73e310f03
commit 91e2918f50
1 changed files with 29 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
RetroFE/Source/Video/GStreamerVideo.cpp
View File

@ -360,15 +360,41 @@ void GStreamerVideo::update(float /* dt */)
int pitch;
unsigned int vbytes = width_ * height_;
vbytes += (vbytes / 2);
SDL_LockTexture(texture_, NULL, &pixels, &pitch);
gst_buffer_extract(videoBuffer_, 0, pixels, vbytes);
SDL_UnlockTexture(texture_);
gsize bufSize = gst_buffer_get_size(videoBuffer_);
if (bufSize == vbytes)
{
SDL_LockTexture(texture_, NULL, &pixels, &pitch);
gst_buffer_extract(videoBuffer_, 0, pixels, vbytes);
SDL_UnlockTexture(texture_);
}
else
{
GstMapInfo bufInfo;
unsigned int y_stride, u_stride, v_stride;
const Uint8 *y_plane, *u_plane, *v_plane;
std::stringstream ss;
y_stride = GST_ROUND_UP_4(width_);
u_stride = v_stride = GST_ROUND_UP_4(y_stride / 2);
gst_buffer_map(videoBuffer_, &bufInfo, GST_MAP_READ);
y_plane = bufInfo.data;
u_plane = y_plane + (height_ * y_stride);
v_plane = u_plane + ((height_ / 2) * u_stride);
SDL_UpdateYUVTexture(texture_, NULL,
(const Uint8*)y_plane, y_stride,
(const Uint8*)u_plane, u_stride,
(const Uint8*)v_plane, v_stride);
gst_buffer_unmap(videoBuffer_, &bufInfo);
}
}
else
{
GstMapInfo y_info, u_info, v_info;
void *y_plane, *u_plane, *v_plane;
int y_stride, u_stride, v_stride;
gst_video_meta_map(meta, 0, &y_info, &y_plane, &y_stride, GST_MAP_READ);
gst_video_meta_map(meta, 1, &u_info, &u_plane, &u_stride, GST_MAP_READ);
gst_video_meta_map(meta, 2, &v_info, &v_plane, &v_stride, GST_MAP_READ);